Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphQL): Fixing set ordering in batchGet of entities #3950

Merged
merged 2 commits into from
Jan 23, 2022

Conversation

jjoyce0510
Copy link
Collaborator

In a recent change, we migrated from using the legacy snapshot-based batchGet method to a new batchGetV2. In the process, we introduced a bug that causes the ordering of results from batchGet to be non-deterministically changed.

These changes have not yet been released. This PR fixes the issue.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 22, 2022

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   15m 4s ⏱️ + 1m 40s
505 tests +1  449 ✔️ +1  56 💤 ±0  0 ±0 

Results for commit d9ef28a. ± Comparison against base commit 8b716ad.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 22, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   37m 1s ⏱️ -53s
   274 tests ±0     274 ✔️ ±0    0 💤 ±0  0 ±0 
1 261 runs  +2  1 233 ✔️ +8  28 💤  - 6  0 ±0 

Results for commit d9ef28a. ± Comparison against base commit 8b716ad.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka merged commit 0da1a6b into datahub-project:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants