Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(superset): fix connection for redshift #3944

Merged
merged 1 commit into from
Jan 28, 2022
Merged

fix(superset): fix connection for redshift #3944

merged 1 commit into from
Jan 28, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jan 21, 2022 •
edited
Loading

https://superset.apache.org/docs/databases/redshift

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   13m 35s ⏱️ +35s
504 tests ±0  448 ✔️ ±0  56 💤 ±0  0 ❌ ±0 

Results for commit f347a30. ± Comparison against base commit d23a5bb.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   35m 15s ⏱️
   274 tests    274 ✔️   0 💤 0 ❌
1 261 runs  1 233 ✔️ 28 💤 0 ❌

Results for commit f347a30.

shirshanka
shirshanka approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 0f2f83f into datahub-project:master Jan 28, 2022
treff7es pushed a commit to treff7es/datahub that referenced this pull request Jan 28, 2022
@anshbansal
fix(ingest): superset - fix connection inference for redshift (datahu…
308dbf2 
…b-project#3944)
@anshbansal anshbansal deleted the fix_redshift_superset branch January 28, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @shirshanka