Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(glossary): owner should be optional as per docs (#3858)" #3910

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Revert "fix(glossary): owner should be optional as per docs (#3858)" #3910

merged 1 commit into from
Jan 18, 2022

Conversation

anshbansal
Copy link
Collaborator

This reverts PR #3858.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka
Copy link
Contributor

thanks @anshbansal! We'll fix up the docs in a future PR.

shirshanka
shirshanka approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   12m 12s ⏱️ - 4m 4s
498 tests  - 5  441 ✔️  - 6  56 💤 ±0  1 ❌ +1 
499 runs   - 4  441 ✔️  - 6  56 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 4213eda. ± Comparison against base commit 3d981e6.

@shirshanka shirshanka merged commit 22efdec into datahub-project:master Jan 18, 2022
@anshbansal anshbansal deleted the revert_glossary_change_owner branch January 18, 2022 17:33
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   36m 12s ⏱️
   274 tests    273 ✔️   0 💤 1 ❌
1 259 runs  1 223 ✔️ 34 💤 2 ❌

For more details on these failures, see this check.

Results for commit 4213eda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @shirshanka