Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(azure-ad): correct default value for username attr #3861

Merged
merged 1 commit into from
Jan 12, 2022
Merged

docs(azure-ad): correct default value for username attr #3861

merged 1 commit into from
Jan 12, 2022

Conversation

iasoon
Copy link
Contributor

@iasoon iasoon commented Jan 10, 2022 •
edited
Loading

As stated earlier in the doc. The "login" attribute does not exist.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   34m 39s ⏱️ -42s
   244 tests ±0     244 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 118 runs   - 2  1 086 ✔️  - 8  32 💤 +6  0 ❌ ±0 

Results for commit f13e881. ± Comparison against base commit bb0943f.

pedro93
pedro93 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for improving the docs @iasoon!

shirshanka
shirshanka approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 130d5ff into datahub-project:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iasoon @shirshanka @pedro93