Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java-emitter): check for null callback #3830

Merged

Conversation

swaroopjagadish
Copy link
Contributor

Null callbacks were not being checked before invocation.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Unit Test Results

     48 files  ±0       48 suites  ±0   47m 46s ⏱️ -54s
   676 tests ±0     624 ✔️ ±0  52 💤 ±0  0 ±0 
1 504 runs  +2  1 426 ✔️ +8  78 💤  - 6  0 ±0 

Results for commit 685fab2. ± Comparison against base commit 9a237e9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit daa20f8 into datahub-project:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants