Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Make url an optional field of the DefaultConfig for business glossary #3817

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Jan 3, 2022

Makes the url field of the DefaultConfig of business glossary optional to keep it consistent with the documentation as well as the definition of GlossaryTermInfo aspect.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Unit Test Results

     48 files       48 suites   48m 55s ⏱️
   663 tests    611 ✔️ 52 💤 0
1 469 runs  1 401 ✔️ 68 💤 0

Results for commit 475b938.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 81bc173 into datahub-project:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants