Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(smoke-test): make tags&terms smoke test wait for ingestion to complete #3812

Merged

Conversation

gabe-lyons
Copy link
Contributor

These dependencies were not brought over, leaving open the opportunity for the test to run before ingestion completed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Unit Test Results

     48 files       48 suites   48m 57s ⏱️
   663 tests    607 ✔️ 56 💤 0
1 469 runs  1 397 ✔️ 72 💤 0

Results for commit 1c68cf0.

@gabe-lyons gabe-lyons force-pushed the gabe--fixTagTermFlakeyTest branch from 1c68cf0 to a4b4736 Compare January 14, 2022 23:26
@github-actions
Copy link

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   16m 4s ⏱️ +56s
502 tests ±0  446 ✔️  - 4  56 💤 +4  0 ±0 

Results for commit a4b4736. ± Comparison against base commit a44b48a.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 3d981e6 into datahub-project:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants