Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transform): adds simple add dataset properties transform #3778

Merged
merged 3 commits into from
Dec 22, 2021
Merged

feat(transform): adds simple add dataset properties transform #3778

merged 3 commits into from
Dec 22, 2021

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 21, 2021 •
edited
Loading

There is already a transform to add custom properties to a dataset by using a callback function.
This PR is adding a simple one on top of the existing one. The new one allows for adding custom properties from the configuration. The same pattern (callback + simple version) has been followed in other transforms too.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 21, 2021 •
edited
Loading

Unit Test Results

     45 files  ±0       45 suites  ±0   44m 56s ⏱️ + 1m 5s
   645 tests +1     593 ✔️ +  1  52 💤 ±0  0 ❌ ±0 
1 449 runs  +7  1 381 ✔️ +13  68 💤  - 6  0 ❌ ±0 

Results for commit 37085af. ± Comparison against base commit 77e3641.

♻️ This comment has been updated with latest results.

@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 21, 2021 14:41
RyanHolstien
RyanHolstien approved these changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shirshanka
shirshanka approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 3fa22e1 into datahub-project:master Dec 22, 2021
@sgomezvillamor sgomezvillamor deleted the simple_add_dataset_properties branch December 23, 2021 07:25
@sgomezvillamor sgomezvillamor mentioned this pull request Dec 23, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgomezvillamor @shirshanka @RyanHolstien