-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): Add "Getting Started" Modal on fresh deployment #3773
feat(UI): Add "Getting Started" Modal on fresh deployment #3773
Conversation
}} | ||
> | ||
<NoMetadataEmpty description="No Metadata Found 😢" /> | ||
<Button style={{ margin: 16 }} onClick={() => setShowGettingStartedModal(true)}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
</BrowseCardContainer> | ||
) : ( | ||
<List | ||
locale={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a list?
const hasIngestedMetadata = | ||
orderedEntityCounts && orderedEntityCounts.filter((entityCount) => entityCount.count > 0).length > 0; | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice useEffect!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This introduces a "Getting Started" modal that shows when no metadata has been ingested into your DataHub instance. Additionally, we inform the user on the home page when the instance does not have metadata. See screenshots below!
Also renamed the links in the top-right drop down to remove unnecessary DataHub prefix. And added "releases" to the mix.
![Screen Shot 2021-12-19 at 6 37 25 PM](https://user-images.githubusercontent.com/17549204/146704053-79dfa3e2-eb55-4aec-9737-e189b68306dc.png)
Checklist