Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add "Getting Started" Modal on fresh deployment #3773

Merged
merged 10 commits into from
Dec 22, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Dec 20, 2021

This introduces a "Getting Started" modal that shows when no metadata has been ingested into your DataHub instance. Additionally, we inform the user on the home page when the instance does not have metadata. See screenshots below!

Screen Shot 2021-12-19 at 6 22 23 PM

Screen Shot 2021-12-19 at 6 22 30 PM

Screen Shot 2021-12-19 at 6 20 26 PM

Also renamed the links in the top-right drop down to remove unnecessary DataHub prefix. And added "releases" to the mix.
Screen Shot 2021-12-19 at 6 37 25 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 20, 2021

Unit Test Results

     45 files       45 suites   49m 35s ⏱️
   644 tests    592 ✔️ 52 💤 0
1 444 runs  1 376 ✔️ 68 💤 0

Results for commit 03f0e0b.

♻️ This comment has been updated with latest results.

}}
>
<NoMetadataEmpty description="No Metadata Found 😢" />
<Button style={{ margin: 16 }} onClick={() => setShowGettingStartedModal(true)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

</BrowseCardContainer>
) : (
<List
locale={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a list?

const hasIngestedMetadata =
orderedEntityCounts && orderedEntityCounts.filter((entityCount) => entityCount.count > 0).length > 0;

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice useEffect!!!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 1a65ea7 into datahub-project:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants