Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): Fix for same schema foreign key reference #3769

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix(ingestion): Fix for same schema foreign key reference #3769

merged 2 commits into from
Dec 20, 2021

Conversation

treff7es
Copy link
Contributor

Fix for showing None schema if foreign key pointed to a table in the same schema

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

Unit Test Results

     45 files  +  1       45 suites  +1   45m 39s ⏱️ + 3m 23s
   644 tests +50     592 ✔️ +50  52 💤 ±0  0 ❌ ±0 
1 444 runs  +60  1 376 ✔️ +66  68 💤  - 6  0 ❌ ±0 

Results for commit 5cf9bd7. ± Comparison against base commit 22cef5f.

♻️ This comment has been updated with latest results.

@treff7es
Fixing linter errors
5cf9bd7 
Adding tests
jjoyce0510
jjoyce0510 approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shirshanka
shirshanka approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 2ee1a78 into datahub-project:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @shirshanka @jjoyce0510