Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ingest): restrict latest mypy version #3756

Merged
merged 1 commit into from
Dec 16, 2021
Merged

build(ingest): restrict latest mypy version #3756

merged 1 commit into from
Dec 16, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 16, 2021 •
edited
Loading

Responding to latest mypy 0.920 release.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     45 files  ±0       45 suites  ±0   44m 42s ⏱️ -48s
   641 tests ±0     589 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 433 runs  +2  1 365 ✔️ +8  68 💤  - 6  0 ❌ ±0 

Results for commit 7778a6f. ± Comparison against base commit 5b5135b.

shirshanka
shirshanka approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit c6f3ddf into datahub-project:master Dec 16, 2021
@hsheth2 hsheth2 deleted the mypy-latest branch December 15, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka