refactor(gms auth): Remove base64 decoding of token service signing key #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into remove-base64-decode-token-service-secret
…into remove-base64-decode-token-service-secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Token Service requires a 256-bit signing key. We had previously assumed this key would be a Base64'd string, but are changing that to relax the requirements for this signing key as UTF-8 string. After this change, anyone who has enabled Metadata Service Authentication which was released last week will need to regenerate their Personal Access Tokens.
Why do this? We want to be more flexible in the signing keys we accept to improve usability. We will handle the base64 encode and decode as required within the Token Service.
Checklist