Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): count profiled tables separately in report #3731

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix(ingest): count profiled tables separately in report #3731

merged 1 commit into from
Dec 14, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 13, 2021

Prior to this change, profiled tables were counted as normal scanned tables (since report_entity_scanned defaults to ent_type="table"), and hence the count of scanned tables was incorrectly reported.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@hsheth2
fix(ingest): count profiled tables separately in report
bfb4639 
Prior to this change, profiled tables were counted as normal scanned
tables, and hence the count of scanned tables was incorrectly reported.
@github-actions
Copy link

Unit Test Results

     45 files  ±0       45 suites  ±0   41m 43s ⏱️ -18s
   634 tests ±0     576 ✔️ ±0  58 💤 ±0  0 ❌ ±0 
1 418 runs  +2  1 344 ✔️ +8  74 💤  - 6  0 ❌ ±0 

Results for commit bfb4639. ± Comparison against base commit a6deaab.

shirshanka
shirshanka approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit f24440e into datahub-project:master Dec 14, 2021
@hsheth2 hsheth2 deleted the profiler-report-coutner branch December 14, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka