Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): adds missing port to the connection bootstrap #3706

Merged
merged 5 commits into from
Dec 13, 2021
Merged

fix(ingestion): adds missing port to the connection bootstrap #3706

merged 5 commits into from
Dec 13, 2021

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 9, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

Unit Test Results

     44 files       44 suites   37m 26s ⏱️
   623 tests    571 ✔️ 52 💤 0 ❌
1 387 runs  1 319 ✔️ 68 💤 0 ❌

Results for commit d2ee394.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 9aa370c into datahub-project:master Dec 13, 2021
@sgomezvillamor sgomezvillamor deleted the sgomezvillamor-patch-1 branch December 15, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @shirshanka