Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(scheduling): re-arrange docs related to scheduling, lineage, CLI #3669

Merged
merged 16 commits into from
Dec 7, 2021
Merged

docs(scheduling): re-arrange docs related to scheduling, lineage, CLI #3669

merged 16 commits into from
Dec 7, 2021

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@anshbansal anshbansal mentioned this pull request Dec 6, 2021
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

Unit Test Results

     44 files  ±0       44 suites  ±0   27m 20s ⏱️ + 1m 21s
   616 tests ±0     564 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 353 runs   - 2  1 279 ✔️  - 8  74 💤 +6  0 ❌ ±0 

Results for commit a681937. ± Comparison against base commit d3081f4.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal changed the title Doc scheduling2 docs(scheduling): add docs related to scheduling, clean up CLI docs Dec 6, 2021
@anshbansal anshbansal marked this pull request as ready for review December 6, 2021 09:50
shirshanka
shirshanka requested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes requested.
need to change receipe to recipe throughout.

@anshbansal anshbansal changed the title docs(scheduling): add docs related to scheduling, clean up CLI docs docs(scheduling): re-arrange docs related to scheduling, lineage, CLI Dec 7, 2021
shirshanka
shirshanka approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit b3ef5ee into datahub-project:master Dec 7, 2021
@anshbansal anshbansal deleted the doc_scheduling2 branch December 8, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @shirshanka