Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): Remove unused PDL from pre-nocode days #3659

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix(model): Remove unused PDL from pre-nocode days #3659

merged 1 commit into from
Dec 3, 2021

Conversation

dexter-mh-lee
Copy link
Contributor

Remove unused PDL to reduce confusion.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

Unit Test Results

     44 files  ±0       44 suites  ±0   27m 42s ⏱️ + 1m 18s
   617 tests  - 2     565 ✔️  - 2  52 💤 ±0  0 ❌ ±0 
1 356 runs   - 2  1 288 ✔️  - 2  68 💤 ±0  0 ❌ ±0 

Results for commit 3c7d442. ± Comparison against base commit d5eddf5.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 8757543 into datahub-project:master Dec 3, 2021
@dexter-mh-lee dexter-mh-lee deleted the dl--cleanup-unused-pdl branch April 4, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter-mh-lee @shirshanka