Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transformer) Adds glossary terms transformer #3657

Merged
merged 2 commits into from
Dec 8, 2021
Merged

feat(transformer) Adds glossary terms transformer #3657

merged 2 commits into from
Dec 8, 2021

Conversation

ecooklin
Copy link
Contributor

@ecooklin ecooklin commented Dec 2, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@ecooklin ecooklin changed the title feat(transformer) Adds glossary terms transformer [WIP] feat(transformer) Adds glossary terms transformer Dec 2, 2021
@ecooklin ecooklin force-pushed the add_dataset_terms_transformer branch from d262165 to 9331051 Compare December 2, 2021 21:04
@ecooklin ecooklin changed the title [WIP] feat(transformer) Adds glossary terms transformer feat(transformer) Adds glossary terms transformer Dec 3, 2021
gabe-lyons
gabe-lyons reviewed Dec 3, 2021
View reviewed changes
README.md
@@ -120,6 +120,7 @@ Here are the companies that have officially adopted DataHub. Please feel free to
- [LinkedIn](http://linkedin.com)
- [Peloton](https://www.onepeloton.com)
- [Saxo Bank](https://www.home.saxo)
- [Stash](https://www.stash.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

gabe-lyons
gabe-lyons reviewed Dec 3, 2021
View reviewed changes
metadata-ingestion/transformers.md
Comment on lines +40 to +41
".*example1.*": ["urn:li:tag:NeedsDocumentation", "urn:li:tag:Legacy"]
".*example2.*": ["urn:li:tag:NeedsDocumentation"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this extension!

gabe-lyons
gabe-lyons reviewed Dec 3, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good on my end but I will defer to someone with more python experience to approve 👍

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Unit Test Results

     43 files   -     1       43 suites   - 1   31m 43s ⏱️ + 5m 19s
   620 tests +    1     568 ✔️ +    1  52 💤 ±0  0 ❌ ±0 
1 187 runs   - 171  1 119 ✔️  - 171  68 💤 ±0  0 ❌ ±0 

Results for commit 0c19b1a. ± Comparison against base commit d5eddf5.

shirshanka
shirshanka approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution @ecooklin 🙏

@shirshanka shirshanka merged commit 1a5121a into datahub-project:master Dec 8, 2021
gabe-lyons pushed a commit to gabe-lyons/datahub that referenced this pull request Dec 9, 2021
@ecooklin
feat(ingest): adds glossary terms transformer (datahub-project#3657)
1707253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecooklin @shirshanka @gabe-lyons