Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(description): fix issue where markdown links are unclickable #3646

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Nov 30, 2021

Added in #2707. This stopProp & preventDefault does not appear do anything productive- tested a few scenarios of expanding/contracting, editing/unediting, etc. All seemed to function with these lines removed. This also allows links to work again!

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     44 files  ±0       44 suites  ±0   26m 36s ⏱️ + 1m 14s
   619 tests ±0     567 ✔️ +1  52 💤 ±0  0  - 1 
1 358 runs  ±0  1 290 ✔️ +1  68 💤 ±0  0  - 1 

Results for commit 72db73f. ± Comparison against base commit a5ec05e.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 21f535b into datahub-project:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants