Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): Handling for special characters in snowflake databases and schemas. #3635

Merged
merged 2 commits into from
Nov 30, 2021
Merged

fix(ingestion): Handling for special characters in snowflake databases and schemas. #3635

merged 2 commits into from
Nov 30, 2021

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Nov 30, 2021

Handling for special characters such as hyphen etc. in snowflake databases and schemas.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

Unit Test Results

     44 files  ±0       44 suites  ±0   27m 28s ⏱️ -13s
   619 tests ±0     567 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 358 runs  ±0  1 290 ✔️ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit 9b618a6. ± Comparison against base commit 7d5da17.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 8008fe3 into datahub-project:master Nov 30, 2021
@shirshanka shirshanka mentioned this pull request Nov 30, 2021
Closed
@shirshanka shirshanka linked an issue Nov 30, 2021 that may be closed by this pull request
Snowflake ingestion errors for tables in schema with non-standard names #3531
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snowflake ingestion errors for tables in schema with non-standard names
2 participants
@rslanka @shirshanka