Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recommendations): Fix issue with recently viewed and most popular recs not showing up #3631

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

Fix issue with recently viewed and most popular recs not showing up when there are special characters in the user URN.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     44 files  ±0       44 suites  ±0   28m 10s ⏱️ -44s
   619 tests ±0     567 ✔️ ±0  52 💤 ±0  0 ±0 
1 356 runs   - 2  1 282 ✔️  - 8  74 💤 +6  0 ±0 

Results for commit 2c06051. ± Comparison against base commit 3e284d8.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit ca6f69f into datahub-project:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants