Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery-usage): Fix filters and event joining logic. #3610

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix(bigquery-usage): Fix filters and event joining logic. #3610

merged 1 commit into from
Nov 23, 2021

Conversation

varunbharill
Copy link
Contributor

  1. Fix allow deny filters when patterns are not present
  2. Still produce read events when join does not happen.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     41 files  ±0       41 suites  ±0   31m 5s ⏱️ - 2m 4s
   610 tests ±0     558 ✔️ +2  52 💤 ±0  0 ❌  - 2 
1 349 runs  ±0  1 281 ✔️ +2  68 💤 ±0  0 ❌  - 2 

Results for commit d16841a. ± Comparison against base commit 8a92365.

shirshanka
shirshanka approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 192cf65 into datahub-project:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunbharill @shirshanka