Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): introducing first isolated smoke test: updating tags & terms #3496

Merged
merged 25 commits into from
Nov 2, 2021

Conversation

gabe-lyons
Copy link
Contributor

This PR establishes the pattern for running smoke tests a more isolated & well factored way. In this new test, tags-and-terms, you see

  1. test-specific data being ingested
  2. data being ingested right before the tests are run and deleted immediately after
  3. tests for a specific surface area written in their own file

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

Unit Test Results

     36 files  ±0       36 suites  ±0   26m 11s ⏱️ + 5m 5s
   481 tests ±0     429 ✔️ ±0  52 💤 ±0  0 ±0 
1 130 runs  ±0  1 062 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit 6729b2e. ± Comparison against base commit dda2078.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka merged commit 4a0ed07 into datahub-project:master Nov 2, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants