fix(datajobs): fetch dataflow properties from a relationship #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
commented
Oct 29, 2021
| </Link> | ||
| <TagContainer> | ||
| <TagTermGroup uneditableGlossaryTerms={glossaryTerms} uneditableTags={tags} maxShow={3} /> | ||
| </TagContainer> |
There was a problem hiding this comment.
these changes are to remove warnings in CI
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Nov 3, 2021
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Nov 6, 2021
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in: #3357.
Historically, we have not been fetching data flows via relationships. Recently, that changed when the
dataFlowfield was deprecated in #3278. In this #3357, that logic was replaced with a shared relationship fragment which had not yet had a select clause for data flows added to it.Followups:
I added a unit test to load this section. This unit test would not have caught this error because the apollo mock doens't take into account what fields are being selected. However, more test coverage on high risk areas is better.
This kind of error was sneaky because it only came up if someone navigating specifically to the Pipeline tab of a Data Task. UI integration tests should make sure to open each tab of each entity, rather than just the main page.
Checklist