Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lineage): some ux improvements to lineage interactions #3478

Merged
merged 2 commits into from
Oct 29, 2021
Merged

feat(lineage): some ux improvements to lineage interactions #3478

merged 2 commits into from
Oct 29, 2021

Conversation

gabe-lyons
Copy link
Contributor

  1. expands the click area of expand buttons so they will be harder to miss
  2. shows hover feedback when hovering over expand buttons
  3. shows loading indicator after clicking and before the additional lineage pops in
  4. Recentering the viz on a new node clears all stored drag state so the user isn't dropped into a very confusing situation

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     58 files  ±0       58 suites  ±0   21m 10s ⏱️ +58s
   525 tests ±0     473 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 174 runs  ±0  1 100 ✔️  - 6  74 💤 +6  0 ❌ ±0 

Results for commit d69c172. ± Comparison against base commit 9ed0879.

shirshanka
shirshanka approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 06548a6 into datahub-project:master Oct 29, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
@gabe-lyons @maggiehays
feat(lineage): some ux improvements to lineage interactions (datahub-…
865d569 
…project#3478)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
@gabe-lyons @shirshanka
feat(lineage): some ux improvements to lineage interactions (datahub-…
8c1f05e 
…project#3478)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
@gabe-lyons @shirshanka
feat(lineage): some ux improvements to lineage interactions (datahub-…
353a62e 
…project#3478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @shirshanka