Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tooltip for owner category in dataset profile page #3470

Merged
merged 1 commit into from
Nov 3, 2021
Merged

add tooltip for owner category in dataset profile page #3470

merged 1 commit into from
Nov 3, 2021

Conversation

saxo-lalrishav
Copy link
Contributor

@saxo-lalrishav saxo-lalrishav commented Oct 27, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@saxo-lalrishav
Copy link
Contributor Author

#3457

@github-actions
Copy link

Unit Test Results

     58 files  ±0       58 suites  ±0   20m 8s ⏱️ - 2m 57s
   525 tests ±0     473 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 174 runs  ±0  1 106 ✔️ +6  68 💤  - 6  0 ❌ ±0 

Results for commit 1f758f7. ± Comparison against base commit 2f03ad8.

@shirshanka
Copy link
Contributor

@saxo-lalrishav : mind dropping in a screenshot?
cc @gabe-lyons

@saxo-lalrishav
Copy link
Contributor Author

image

Attached screenshot
@shirshanka

shirshanka
shirshanka approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @saxo-lalrishav

@shirshanka shirshanka merged commit a5ec592 into datahub-project:master Nov 3, 2021
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
@saxo-lalrishav @shirshanka
feat(ui): add tooltip for owner category (datahub-project#3470)
025db61
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
@saxo-lalrishav @shirshanka
feat(ui): add tooltip for owner category (datahub-project#3470)
4c8aac5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saxo-lalrishav @shirshanka