Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix up yarn test error reporting #3462

Merged

Conversation

gabe-lyons
Copy link
Contributor

Yarn test has collected a large number of warnings which makes it very difficult to parse through in CI. This PR addresses all those warnings. Output of yarn test now:

 PASS  src/app/entity/glossaryTerm/profile/__tests__/GlossaryTermHeader.test.tsx (8.676 s)
 PASS  src/app/entity/dataset/profile/__tests__/Properties.test.tsx (8.778 s)
 PASS  src/app/entity/dataset/profile/__tests__/SchemaDescriptionField.test.tsx (9.065 s)
 PASS  src/App.test.tsx (9.668 s)
 PASS  src/app/entity/dataset/profile/__tests__/Stats.test.tsx
 PASS  src/app/entity/shared/containers/profile/__tests__/EntityProfile.test.tsx
 PASS  src/app/home/__tests__/HomePage.test.tsx
 PASS  src/app/entity/dataset/profile/__tests__/Schema.test.tsx (5.468 s)
 PASS  src/app/search/__tests__/SearchPage.test.tsx
 PASS  src/app/entity/glossaryTerm/preview/__tests__/Preview.test.tsx
 PASS  src/app/shared/tags/__tests__/TagTermGroup.test.tsx
 PASS  src/app/entity/tag/__tests__/TagProfile.test.tsx
 PASS  src/app/entity/mlModel/__tests__/MlModelProfile.test.tsx
 PASS  src/app/shared/entitySearch/__tests__/RelatedEntity.test.tsx
 PASS  src/app/entity/glossaryTerm/profile/__tests__/GlossaryRelatedTerms.test.tsx
 PASS  src/app/shared/entitySearch/__tests__/RelatedEntityResult.test.tsx
 PASS  src/app/entity/dataset/profile/__tests__/Lineage.test.tsx
 PASS  src/app/lineage/__tests__/adjustVXTreeLayout.test.tsx
 PASS  src/app/entity/shared/tabs/Documentation/__tests__/DocumentationTab.test.tsx
 PASS  src/app/entity/mlModelGroup/__tests__/MlModelGroupProfile.test.tsx
 PASS  src/app/entity/dataset/profile/__tests__/Documentation.test.tsx
 PASS  src/utils/sort/__tests__/topologicalSort.test.ts
 PASS  src/app/entity/user/__tests__/UserHeader.test.tsx
 PASS  src/app/lineage/__tests__/constructTree.test.ts
 PASS  src/app/lineage/__tests__/LineageTree.test.tsx

Test Suites: 25 passed, 25 total
Tests:       64 passed, 64 total
Snapshots:   0 total
Time:        25.249 s, estimated 28 s
Ran all test suites related to changed files.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

  39 files  ±0    39 suites  ±0   18m 54s ⏱️ +58s
314 tests ±0  314 ✔️ ±0    0 💤 ±0  0 ±0 
963 runs  ±0  941 ✔️ ±0  22 💤 ±0  0 ±0 

Results for commit 28bec8c. ± Comparison against base commit 561c04b.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 3739420 into datahub-project:master Oct 26, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants