Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Workaround for Python 3.8/3.9 mypy invalid syntax issue with airflow 2.2.0 #3460

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Oct 26, 2021

Fixes the linter error: "venv/lib/python3.9/site-packages/airflow/_vendor/connexion/spec.py:169: error: invalid syntax" when building :metadata-ingestion:lint with Python 3.8/3.9. Also adds building :metadata-ingestion with Python 3.9 to the github build & test workflow.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

  39 files  ±0    39 suites  ±0   20m 12s ⏱️ + 2m 16s
314 tests ±0  314 ✔️ ±0    0 💤 ±0  0 ±0 
963 runs  ±0  941 ✔️ ±0  22 💤 ±0  0 ±0 

Results for commit dd0c9c8. ± Comparison against base commit 561c04b.

@rslanka rslanka changed the title fix(ingest): Workaround for Python 3.8/3.9 mypy invalid syntax issue with airflow 2.2.0 fix(ingestion): Workaround for Python 3.8/3.9 mypy invalid syntax issue with airflow 2.2.0 Oct 26, 2021
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 34a5d5c into datahub-project:master Oct 26, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants