Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tag+terms): improved error messaging & rules on tag + term mutations #3448

Merged
merged 1 commit into from
Oct 25, 2021
Merged

fix(tag+terms): improved error messaging & rules on tag + term mutations #3448

merged 1 commit into from
Oct 25, 2021

Conversation

gabe-lyons
Copy link
Contributor

  1. Datahub was not properly translating the IllegalArgumentExceptions in DataHubDataFetcherExceptionHandler.java causing the error messages to get swallowed. This has been fixed:

image

  1. Datahub was enforcing tag existence on additions and removals. That meant if a non-existent tag or term was added in ingestion, it could not be removed via mutation. This PR removes the existence check for the tag/term on removal.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

shirshanka
shirshanka approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit d3d7593 into datahub-project:master Oct 25, 2021
@shirshanka shirshanka mentioned this pull request Oct 25, 2021
Closed
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
@gabe-lyons @maggiehays
fix(graphql): fix errors on tag & term mutations (datahub-project#3448)
1c5541c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @shirshanka