feat(quickstart): Simplify docker generate and compare script #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
changed the title
gabe-lyons
reviewed
Oct 25, 2021
| MONITORING_COMPOSE="-f quickstart/docker-compose.quickstart.monitoring.yml" | ||
| MONITORING_COMPOSE="-f quickstart/docker-compose.monitoring.quickstart.yml" |
There was a problem hiding this comment.
out of curiosity, what was the motivation behind this change?
There was a problem hiding this comment.
To be able to include the '.monitor' flavour in the for loop to avoid a separate if cmp code block for that file. And it better aligns with the naming in docker/monitoring.
In https://github.com/EnricoMi/datahub/pull/6/files#diff-135ef7fb531c210baeeab0b42a4e2589366367ea773e52c524140844eb583b8b I am adding more quickstart files and #3286 might also want a quickstart flavour one day.
gabe-lyons
reviewed
Oct 25, 2021
| printf 'docker-compose.quickstart.yml is out of date.' | ||
| python generate_docker_quickstart.py ../monitoring/docker-compose.monitoring.yml temp.monitoring.quickstart.yml | ||
|
|
||
| for flavour in "" "-without-neo4j" ".monitoring" |
There was a problem hiding this comment.
let's make this a constant declared at the top of the file
EnricoMi
force-pushed
the
branch-docker-generate-and-compare
branch
from
b9a1f1e to
b5eb5a2
Compare
|
@gabe-lyons is this good to go? |
|
@EnricoMi : sorry for the radio silence on this one, we'll shepherd this in this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is
docker/monitoring/docker-compose.monitoring.ymlbutdocker/quickstart/docker-compose.quickstart.monitoring.yml. If both filenames follow the same naming scheme, i.e.docker-compose.monitoring.quickstart.yml, then some code duplication indocker/quickstart/generate_and_compare.shcould be reduced:There might more quickstart scripts being added in the future, e.g. for #3261 (see https://github.com/EnricoMi/datahub/pull/6/files#diff-135ef7fb531c210baeeab0b42a4e2589366367ea773e52c524140844eb583b8b) which would benefit from this.