fix(ingest): redshift source gets external table types properly #3371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the redshift source failed to get varchar sizes and because of this all the varchars become NullType.
Here is the corresponding sqlalchemy code why this happened -> https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/blob/75db33620b87e732386b1b63986b67d058689f6c/sqlalchemy_redshift/dialect.py#L694
I changed the query back to the sqlalchemy default (https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/blob/75db33620b87e732386b1b63986b67d058689f6c/sqlalchemy_redshift/dialect.py#L777) and I unioned the external tables to it as well.
This way the varchar sizes showed up properly and even column encoding and dist/sort keys get populated.
The only caveat was that the external column types are different from the postgres types, so I had to map those to one of the redshift types. -> https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_EXTERNAL_TABLE.html (see datatypes part)
Here is a comparison how the columns looked like with the old query:
How it looks like with the new query:
Checklist