Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add run_id to the task instance constructor for airflow #3366

Merged

Conversation

swaroopjagadish
Copy link
Contributor

@swaroopjagadish swaroopjagadish commented Oct 12, 2021

Airflow recently released 2.2.0 which changes the behavior of task instance construction when a run_id is not provided (attempts to load up the run_id from the sqlite db).
This breaks CI tests.

Fixing this by providing a dummy run_id since we don't really use it.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 7dab065 into datahub-project:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants