Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mce_builder): deleted alias #3356

Merged
merged 1 commit into from
Oct 11, 2021
Merged

fix(mce_builder): deleted alias #3356

merged 1 commit into from
Oct 11, 2021

Conversation

vlavorini
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was this causing trouble on your side?

@vlavorini
Copy link
Contributor Author

Yes, while emitting lineage info from an Airflow job, example:

from datahub_provider.entities import Dataset

@task(inlets={"datasets": [Dataset(...)]},
       outlets=AUTO)
def that_task():
    ...

The class Dataset in fact uses a function defined in that builder, hence the issue came out.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit f39b868 into datahub-project:master Oct 11, 2021
@vlavorini vlavorini deleted the mce_builder_fix branch October 12, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants