Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): no error when there are no partition keys #3328

Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix(ingest): no error when there are no partition keys #3328

merged 1 commit into from
Oct 5, 2021

Conversation

aseembansal-gogo
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka shirshanka added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 5, 2021
shirshanka
shirshanka approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit e850202 into datahub-project:master Oct 5, 2021
@aseembansal-gogo aseembansal-gogo deleted the fix_keyerror branch October 5, 2021 14:41
jgiannuzzi pushed a commit to G-Research/datahub that referenced this pull request Oct 6, 2021
@aseembansal-gogo @jgiannuzzi
fix(ingest): glue ingestion should not fail when there are no partiti…
8703e20 
…on keys (datahub-project#3328)
swaroopjagadish pushed a commit to swaroopjagadish/datahub that referenced this pull request Oct 7, 2021
@aseembansal-gogo @swaroopjagadish
fix(ingest): glue ingestion should not fail when there are no partiti…
b2cc898 
…on keys (datahub-project#3328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aseembansal-gogo @shirshanka