Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users & groups): User & Groups Management GraphQL APIs + UI #3318

Merged
merged 19 commits into from
Oct 7, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Oct 1, 2021

Status
Ready for review

Changes
Adding GraphQL APIs for the following user and groups management capabilities:

  • createGroup
  • removeGroup
  • removeUser
  • addGroupMember
  • removeGroupMember
  • listUsers
  • listGroups

And also the UI for listing all users and groups on DataHub, additionally allowing users with the MANAGE_USERS_AND_GROUPS permission to:

  1. Delete users and groups
  2. Create groups
  3. Add and remove members from groups

Some additional misc. changes:

  • add a "CorpUserStatus" aspect which determines whether the user is active or not.
  • add a "list" API in the EntityResource which allows you to list entities from an elastic index. This builds on the "filter" api exposed by the SearchService

Each of these changes are prerequisites to the groups management UI we are working to build.

Screenshots!

Screen Shot 2021-10-06 at 7 03 51 PM

Screen Shot 2021-10-06 at 7 03 42 PM

Screen Shot 2021-10-06 at 7 03 24 PM

Screen Shot 2021-10-06 at 7 03 15 PM

Screen Shot 2021-10-06 at 7 03 09 PM

Compatibility
Fully compatible with previous versions.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 jjoyce0510 changed the title feat(users & groups): User & Groups Management GraphQL APIs feat(users & groups): User & Groups Management GraphQL APIs + UI Oct 7, 2021
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit ed01b59 into datahub-project:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants