feat(ingest): support for primary and foreign key extraction from sql sources #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Oct 1, 2021
| @@ -251,6 +258,12 @@ def get_schema_metadata( | |||
| nullable=column["nullable"], | |||
| recursive=False, | |||
| ) | |||
| if ( | |||
| pk_constraints is not None | |||
| and isinstance(pk_constraints, dict) # some dialects (hive) return list | |||
shirshanka
reviewed
Oct 1, 2021
shirshanka
approved these changes
Oct 1, 2021
xdl
pushed a commit
to G-Research/datahub
that referenced
this pull request
Oct 4, 2021
xdl
added a commit
to G-Research/datahub
that referenced
this pull request
Oct 5, 2021
…from sql sources (datahub-project#3316)" This reverts commit 02aa342.
jgiannuzzi
pushed a commit
to G-Research/datahub
that referenced
this pull request
Oct 6, 2021
swaroopjagadish
added a commit
to swaroopjagadish/datahub
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with mysql, sql server.
Should work for all sql systems.
Checklist