feat(oidc): Support NONE client auth method in OIDC (stopgap) #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdl
pushed a commit
to G-Research/datahub
that referenced
this pull request
Oct 4, 2021
xdl
added a commit
to G-Research/datahub
that referenced
this pull request
Oct 5, 2021
jgiannuzzi
pushed a commit
to G-Research/datahub
that referenced
this pull request
Oct 6, 2021
swaroopjagadish
pushed a commit
to swaroopjagadish/datahub
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received a few asks from the community to supporting the "NONE" OIDC authentication method. This PR introduces that support by extending Pac4j's default OIDC Client + Authenticator classes.
An alternative solution to this would have been upgrading Play & Pac4j, which proved very challenging due to the Play Gradle plugin we are leveraging. The long term solution will involve performing this upgrade, if possible.
Checklist