fix: use wait-http-header to avoid printing cleartext credentials #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass basic auth credentials to -wait-http-header inside a header basic auth credentials were printed on failure to the console together with the elasticsearch url. Passing them as headers explicitly avoids this unwanted behaviour
shirshanka
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing the basic auth credentials embedded within the Elasticsearch url, those are printed out to the console in case of authentication failure.
For example:
Passing those credentials as headers via the
-wait-http-headerparameter prevents this leakage and works as well.I tested the container on AWS both with basic authentication enabled and disabled.
Related issues: #2933
Checklist