-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): Auto Ingestion Data Platforms on GMS boot #3219
feat(ingest): Auto Ingestion Data Platforms on GMS boot #3219
Conversation
|
||
private final EntityService _entityService; | ||
|
||
public IngestDataPlatformsStep(final EntityService entityService) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@requiredargsconstructor will take care of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appartently not. It throws an error.
error: constructor IngestPoliciesStep in class IngestPoliciesStep cannot be applied to given types;
final IngestPoliciesStep ingestPoliciesStep = new IngestPoliciesStep(_entityService);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist