prevent NoneType exception when profiling empty datasets #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Aug 23, 2021
| @@ -219,7 +219,8 @@ def _handle_convert_column_evrs( # noqa: C901 (complexity) | |||
| elif exp == "expect_column_values_to_not_be_null": | |||
| column_profile.nullCount = res["unexpected_count"] | |||
| if "unexpected_percent" in res: | |||
There was a problem hiding this comment.
I think the system can handle column_profile.nullProportion = None, so how about only setting it only when both of these are true.
So I guess:
if "unexpected_percent" in res and res["unexpected_percent"] is not None:
column_profile.nullProportion = res["unexpected_percent"]
There was a problem hiding this comment.
That makes totally sense. I will try that!
|
@sgomezvillamor : seems like lint is complaining (https://github.com/linkedin/datahub/pull/3144/checks?check_run_id=3402002680) You can fix it via: Also I had a suggestion for rewriting the check and combining it with the previous. |
sgomezvillamor
changed the title
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Aug 27, 2021
…ts (datahub-project#3144) Co-authored-by: Sergio Gómez <[email protected]>
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Aug 31, 2021
…ts (datahub-project#3144) Co-authored-by: Sergio Gómez <[email protected]>
rahulbsw
pushed a commit
to rahulbsw/datahub
that referenced
this pull request
Sep 2, 2021
…ts (datahub-project#3144) Co-authored-by: Sergio Gómez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res["unexpected_percent"]isNoneTypewhen profiling empty datasets and the division causes an exception. This PR is preventing that scenario.Issue #3132
Checklist