Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): Change consumer id of mae/mce processor #3135

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

The consumer id env variable is the same between MAE/MCE processor. This was fine before when the mae/mce containers were separated, but not that they are in the same gms pod, setting the env variable causes exception. Details #3133

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit a6402f6 into datahub-project:master Aug 21, 2021
@shirshanka
Copy link
Contributor

Fixes #3133

shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Aug 27, 2021
gabe-lyons pushed a commit to gabe-lyons/datahub that referenced this pull request Aug 31, 2021
rahulbsw pushed a commit to rahulbsw/datahub that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants