Migrating GraphQL API to GMS #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Aug 20, 2021
| @Security.Authenticated(Authenticator.class) | ||
| public CompletableFuture<Result> proxy(String path) throws ExecutionException, InterruptedException { | ||
| final String resolvedUri = PATH_REMAP.getOrDefault(request().uri(), request().uri()); | ||
| return _ws.url(String.format("http://%s:%s%s", GMS_HOST, GMS_PORT, resolvedUri)) |
There was a problem hiding this comment.
will this always be http?
There was a problem hiding this comment.
See comment above^ in order to serve mutual auth, we'll have to do some additional client side configuration work. I don't want to include that here. Think I should create a ticket?
shirshanka
approved these changes
Aug 20, 2021
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Aug 27, 2021
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Aug 31, 2021
rahulbsw
pushed a commit
to rahulbsw/datahub
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Changes
This PR includes a migration of the GraphQL API from the datahub-frontend server (ui web server) to the DataHub backend service (GMS). This consolidation is being done for a few reasons:
In doing so, we've added an additional API Spring MVC servlet at the GMS layer. In the near future, we intend for this to be the primary place for requesting API resources from DataHub.
In addition to moving the GraphQL API, we've also begun to rebrand "GMS" as the "Metadata Service", a much more comprehensible name for service responsible for persisting and serving the Metadata Graph.
Compatibility
Luckily, no changes in this PR are necessarily backwards incompatible. The frontend Play server will simply proxy to the GraphQL API hoisted at GMS, using the exact same GraphQL model and components for resolving the Graph. The UI will continue to speak to the datahub-frontend web server directly.
The GraphQL infrastructure will continue to speak directly to general-purpose Rest.li endpoints (entities, aspects, relationships), only now that call will be local to the same process.
The Future
The future is bright for the Metadata Service! Coming soon with be a rich Authentication model at the API layer along with fine-grained access controls dictating who can do what on the DataHub platform. Stay tuned fo exciting work coming in the weeks ahead!
Checklist