Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat)(Business Glossary) glossary term relationship graphql changes #3103

Merged
merged 12 commits into from
Aug 18, 2021
Merged

(feat)(Business Glossary) glossary term relationship graphql changes #3103

merged 12 commits into from
Aug 18, 2021

Conversation

saxo-lalrishav
Copy link
Contributor

@saxo-lalrishav saxo-lalrishav commented Aug 17, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@saxo-lalrishav saxo-lalrishav mentioned this pull request Aug 17, 2021
Closed
4 tasks
@gabe-lyons
Copy link
Contributor

Looking good- as discussed offline, we can move to use the new relationship type introduced here:

https://github.com/linkedin/datahub/pull/3094/files#diff-e04c9c2d80cbfd7aa7e3e0f867248464db0f6497684661132d6ead81ded21856R443

gabe-lyons
gabe-lyons reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! will you also add the UI as part of this change?

@saxo-lalrishav
Copy link
Contributor Author

Yes will raise a new PR for React

gabe-lyons
gabe-lyons approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shirshanka
shirshanka approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 24dc67f into datahub-project:master Aug 18, 2021
rahulbsw pushed a commit to rahulbsw/datahub that referenced this pull request Sep 2, 2021
@saxo-lalrishav
feat(business-glossary): glossary term relationship graphql changes (d…
27d190e 
…atahub-project#3103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saxo-lalrishav @gabe-lyons @shirshanka