Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(group ui): Basic group search membership in UI #3094

Merged
merged 25 commits into from
Aug 17, 2021
Merged

feat(group ui): Basic group search membership in UI #3094

merged 25 commits into from
Aug 17, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Aug 13, 2021 •
edited
Loading

Changes

  • Enable Search on CorpGroups
  • Display paginated Group Members on the Group Profile Page (& the assets the group owns)
  • Backwards compatible change to the EntityRelationship.pdl model returned for the "get relationships" endpoint: Renaming 'entities' to 'relationships' for consistency. Only one dependency exists within the system, which was updated.

Ready for review.

Screen Shot 2021-08-13 at 4 15 11 PM

Notice the pagination.

Screen Shot 2021-08-12 at 6 29 57 PM

Screen Shot 2021-08-12 at 7 04 42 PM

Screen Shot 2021-08-12 at 7 02 58 PM

Validation

Verified these changes with curls against GMS deployed in both the Neo4j and Elastic Graph Service modes.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka
Copy link
Contributor

Excited to see User and Group management progressing inside of the UI. Ship!

@shirshanka shirshanka merged commit f40bf1c into datahub-project:master Aug 17, 2021
rahulbsw pushed a commit to rahulbsw/datahub that referenced this pull request Sep 2, 2021
@jjoyce0510
feat(group ui): Basic group search membership in UI (datahub-project#…
6310bb1 
…3094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjoyce0510 @shirshanka @gabe-lyons