fix(postgres): postgres setup #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/postgres-setup/Dockerfile
Outdated
| @@ -6,6 +6,6 @@ COPY docker/postgres-setup/init.sql /init.sql | |||
| COPY docker/postgres-setup/init.sh /init.sh | |||
| RUN chmod 755 init.sh | |||
|
|
|||
| ENV DATAHUB_DB_NAME="datahub" | |||
| ENV DATAHUB_DB_NAME=$POSTGRES_DATABASENAME | |||
There was a problem hiding this comment.
Why do we need a separate env variable?
There was a problem hiding this comment.
Can we just use DATAHUB_DB_NAME ?
There was a problem hiding this comment.
I guess we don't need it. Initial intention is for the users to be able set their own database name through the env. But if it's unnecessary, we can remove it!
There was a problem hiding this comment.
So DATAHUB_DB_NAME already does that. Here it seems like it's always set to "datahub" but it does use the appropriate db name during setup.(This is the case for mysql-setup, where I tested with different db names)
rahulbsw
pushed a commit
to rahulbsw/datahub
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error in the init.sql. Postgres SQL doesn't support
CREATE DATABASE IF NOT EXISTS, so I have added a psql shell script in the init.sh to check whether there's the database we want, if notcreate database datahub. And also some minor changes in the sql file. Such as we can use the TEMP table syntax when we create a temp table.Checklist