feat(nested avro): Adding support for nested avro schema ingestion #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added type annotations to fields 2. Emitting non-leaf level fields as well.
1. Enhanced to emit all intermeidate AVRO nodes also as MCE schema fields. 2. Converted SchemaField list generation logic to use Python generator functions for better memory utilization. 3. Update unit tests.
1. Skipping the generation of intermeidate unions that are originally optional fields i.e. union(null, SomeType). 2. Eliminated redundant `[member=T]` and `[value=T] annotations.
…from value schema.
1. Skip emitting SchemaFields for 'null' member of unions. 2. Harden tests to ensure uniqueness of the fieldPath for SchemaFields corresponding to the actual AVRO fields (non-intermediate).
… types before a field, since they don't offer much value.
…ying type for optionals, instead of a union that Avro parser converts these to
gabe-lyons
approved these changes
Aug 11, 2021
rahulbsw
pushed a commit
to rahulbsw/datahub
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist