feat(react): update search result has result counts for each entities that has result #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
reviewed
Jul 30, 2021
| @@ -6,7 +6,7 @@ import { useGetUserQuery } from '../graphql/user.generated'; | |||
| * Fetch a CorpUser object corresponding to the currently authenticated user. | |||
| */ | |||
| export function useGetAuthenticatedUser() { | |||
| const userUrn = Cookies.get(CLIENT_AUTH_COOKIE); | |||
| const userUrn = process.env.JEST_WORKER_ID !== undefined ? 'urn:li:corpuser:1' : Cookies.get(CLIENT_AUTH_COOKIE); | |||
There was a problem hiding this comment.
let's not include anything related to tests in this method- if you need to mock this it should be mocked in the test file itself.
gabe-lyons
reviewed
Jul 30, 2021
Comment on lines
162
to
164
| <StyledNumberInTab>{` (${countFormatter( | ||
| resultCounts[type] || 0, | ||
| )})`}</StyledNumberInTab> |
There was a problem hiding this comment.
let's remove the parentheses now that the text is gray
gabe-lyons
reviewed
Jul 30, 2021
Comment on lines
+100
to
+104
| analytics.event({ | ||
| type: EventType.SearchResultsViewEvent, | ||
| query, | ||
| total: resultCount, | ||
| }); |
There was a problem hiding this comment.
please move the analytics event into its own useEffect- it is a bit confusing that this is a side effect of the use memo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist