Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tags): fixing tag applied to module for tags w/ colons in the name #2982

Merged
merged 2 commits into from
Jul 29, 2021
Merged

fix(tags): fixing tag applied to module for tags w/ colons in the name #2982

merged 2 commits into from
Jul 29, 2021

Conversation

gabe-lyons
Copy link
Contributor

The search query that populates this module was not quoting the search term, so tags with colons were not properly being found.

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka
Copy link
Contributor

@gabe-lyons Looks like :datahub-web-react:yarnTest failed

shirshanka
shirshanka approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 242ca71 into datahub-project:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @shirshanka