Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ingest): remove unused variable in Looker ingestion #2979

Merged
merged 1 commit into from
Jul 29, 2021
Merged

perf(ingest): remove unused variable in Looker ingestion #2979

merged 1 commit into from
Jul 29, 2021

Conversation

jameslamb
Copy link
Contributor

I've been looking at opportunities to contribute on metadata ingestion, so I ran pylint metadata-ingestion/src/datahub today.

This PR proposes fixing one of the warnings raised by pylint.

metadata-ingestion/src/datahub/ingestion/source/looker.py:163:16: W0612: Unused variable 'expression' (unused-variable)

This PR proposes removing that variable, which I think should make the Looker ingestion code a tiny tiny tiny bit faster and, more importantly, eliminates the risk of that code breaking if the key "expression" doesn't show up in the parsed fields.

Thanks for your time and consideration.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit b2dc4b9 into datahub-project:master Jul 29, 2021
@jameslamb jameslamb deleted the fix/unused branch July 29, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants