perf(ingest): remove unused variable in Looker ingestion #2979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking at opportunities to contribute on metadata ingestion, so I ran
pylint metadata-ingestion/src/datahub
today.This PR proposes fixing one of the warnings raised by
pylint
.This PR proposes removing that variable, which I think should make the Looker ingestion code a tiny tiny tiny bit faster and, more importantly, eliminates the risk of that code breaking if the key
"expression"
doesn't show up in the parsed fields.Thanks for your time and consideration.
Checklist