fix(ingest): map all LookML dimension types to corresponding avro types #2972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when ingesting metadata for LookML files using the current state of
master
in this repo, I was getting warnings like the following:I believe that's because some valid dimension types in LookML haven't been added to the mapping in
datahub
's LookML ingestion code. You can see the full list of dimension types at https://docs.looker.com/reference/field-reference/dimension-type-reference.This pull request extends the work that was done in #2950 to map LookML dimension types to the corresponding avro types.
Checklist
Notes for Reviewers
I wasn't really sure what the right choice was for types like
date_day_of_week_index
(which is e.g. 0 on Sunday, 1 on Monday). I don't understand the implication of treating data like that asEnumTypeClass
vs.NumberTypeClass
. I expect reviewers will have some suggested changes to the types I chose here.Thanks for your time and consideration!