Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): extract lineage between SageMaker jobs and models #2868

Merged
merged 7 commits into from
Jul 16, 2021
Merged

feat(ingest): extract lineage between SageMaker jobs and models #2868

merged 7 commits into from
Jul 16, 2021

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Jul 12, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@kevinhu kevinhu marked this pull request as ready for review July 12, 2021 22:35
hsheth2
hsheth2 requested changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits but otherwise LGTM

metadata-ingestion/src/datahub/ingestion/source/sagemaker_processors/jobs.py Outdated
job_direction: str # 'training' or 'downstream'

# add hash method so we can store these in a set
def __hash__(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to set frozen=True in the dataclass and avoid writing your own hash method

metadata-ingestion/src/datahub/ingestion/source/sagemaker_processors/jobs.py Outdated
"""

job_urn: str
job_direction: str # 'training' or 'downstream'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be an enum

hsheth2
hsheth2 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dexter-mh-lee
dexter-mh-lee approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

shirshanka
shirshanka approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 44ed2f3 into datahub-project:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

@shirshanka shirshanka shirshanka approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinhu @dexter-mh-lee @shirshanka @hsheth2